You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Enchantment Extractors aren't based on custom crafters and therefore don't check for a custom crafters existence on creation (the same goes for custom crafters). This makes it possible to create an enchantment extractor inside a custom crafter and vice versa. The resulting machine acts as both Enchantment Extractor and Custom Crafter and displays both top textures.
This does not break any functionality nor does it enable any exploits, it just looks glitchy.
To Reproduce
Steps to reproduce the behavior:
Create a Custom Crafter or Enchantment Extractor
Use the Machine to create an Enchantment Extractor or Custom Crafter
You'll end up with an Enchantment Extractor and Custom Crafter in a single block
Expected behavior
These should not be peaceable in the same block space.
Fix
The modules have to check for each other upon machine creation - or even better neither of them should be craftable if there is already an armor stand in the dropper. This would enable compatibility with all dropper based machines.
Alternatively, Enchantment Extractora could be turned into a Custom Crafters expansion. It feels weird that this machine that is also based on a dropper is not a Custom Crafters upgrade. The general armor stand check as described above might still be a good ideax though.
Screenshots
Screenshots tba.
Environment
Minecraft version: 1.14
Server version: Spigot 1.14 ; Gamemode 4 Public Server 4
Relates Issues #76 is caused by the same missing check, just with hoppers instead of droppers as a base block.
The text was updated successfully, but these errors were encountered:
I was thinking we could fix this by looking for an armor_stand with the gm4_no_edit tag already in the dropper when making a new machine. While not the most elegant solution (that might have some conflicts with different sized stands), it would fix all the strange issues with compressors inside custom crafters or enchant extractors inside master crafters ect....
Enchantment Extractors can no longer be made within Custom Crafters.
However Custom Crafters can still be made within an Enchantment Extractor. All items used to make the Enchantment Extractor will pop out and the Custom Crafter cannot be used as an Enchantment Extractor. Other than the replacement of the Enchantment Extractor, I would say this is no longer a bug.
Describe the bug
Enchantment Extractors aren't based on custom crafters and therefore don't check for a custom crafters existence on creation (the same goes for custom crafters). This makes it possible to create an enchantment extractor inside a custom crafter and vice versa. The resulting machine acts as both Enchantment Extractor and Custom Crafter and displays both top textures.
This does not break any functionality nor does it enable any exploits, it just looks glitchy.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
These should not be peaceable in the same block space.
Fix
The modules have to check for each other upon machine creation - or even better neither of them should be craftable if there is already an armor stand in the dropper. This would enable compatibility with all dropper based machines.
Alternatively, Enchantment Extractora could be turned into a Custom Crafters expansion. It feels weird that this machine that is also based on a dropper is not a Custom Crafters upgrade. The general armor stand check as described above might still be a good ideax though.
Screenshots
Screenshots tba.
Environment
Relates Issues
#76 is caused by the same missing check, just with hoppers instead of droppers as a base block.
The text was updated successfully, but these errors were encountered: