Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid Tanks Utilities do not run when powered #424

Closed
Bloo-dev opened this issue Jun 16, 2020 · 5 comments
Closed

Liquid Tanks Utilities do not run when powered #424

Bloo-dev opened this issue Jun 16, 2020 · 5 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Bloo-dev
Copy link
Member

Describe the bug
Liquid Tanks do not process utilities when powered. This makes automation really hard as the liquid tank needs to be locked to not forward the item waiting to be filled inside.

To Reproduce
Steps to reproduce the behavior:

  1. Place a witch on a Liquid Tank
  2. Power the Liquid Tank
  3. Watch the witch NOT fill the tank

Expected behavior
The witch should not care about redstone.

Fix
Remove the [enabled=true] check.

Screenshots
image

Environment

  • Minecraft version: 1.15.2
  • Server version: Public Server 6 (1.15.2)
@Bloo-dev Bloo-dev added bug Something isn't working needs investigation labels Jun 16, 2020
@Bloo-dev
Copy link
Member Author

Here is a workaround. As you can see it's a lot bigger.
image

@Kroppeb
Copy link
Contributor

Kroppeb commented Jun 16, 2020

I think this is working as intended

@SpecialBuilder32
Copy link
Member

This is a feature for enabling/disabling the tank actions, with the unfortunate side effect of also disabling hopper actions. As I think I see in your workaround picture, you can treat the tank as a part of an item filter and lock the hopper below it to achieve the same effect.
I think this is okay, since if you pretend the tank is just like any other container in the game, you would need a second hopper to move items in/out.
Codewise it would also require checking the powered state for each different entity interaction, since you'd still want to disable things like cauldron filling (which is an entity interaction)

@Bloo-dev
Copy link
Member Author

Would syncing the Liquid Tank main clock to hopper speed be a feasible compromise?

@SpecialBuilder32
Copy link
Member

Wouldn't that not even help? There's no way to align your hoppers with the clock, even if they go at the same rate right? That's the entire reason the you needed the magic lever for the zauber cauldron auto-brewer on PSIII.

@Bloo-dev Bloo-dev added the wontfix This will not be worked on label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants