Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing Heart Canisters update PR #515 causes additional hearts #537

Closed
Bloo-dev opened this issue Mar 9, 2021 · 1 comment
Closed
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Bloo-dev
Copy link
Member

Bloo-dev commented Mar 9, 2021

Describe the bug
When installing #515 onto a world which previously had Heart Canisters installed, players with existing heart can keep their health boost effect and gain extra hearts.

To Reproduce
Steps to reproduce the behavior:

  1. Install a pre Health Boost potion effect -> Attribute modifiers #515 version of Heart Canisters and put some Heart Canisters in your inventory
  2. Install update Heart Canisters to post Health Boost potion effect -> Attribute modifiers #515
  3. Notice you have more hearts than expected and a leftover health boost effect.

Expected behavior
The health boost effect should be removed.

Fix
Remove the health boost effect from players that had heart canisters once.

Environment

  • Minecraft version: 1.16.5
@Bloo-dev Bloo-dev added bug Something isn't working wontfix This will not be worked on labels Mar 9, 2021
@Bloo-dev
Copy link
Member Author

Bloo-dev commented Mar 9, 2021

Won't fix. Milk or death fixes it.

@Bloo-dev Bloo-dev closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant