Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Methods Split into PC and Xbox for 2.0.0 and Potential Delays #80

Closed
GavinPower747 opened this issue Oct 3, 2018 · 3 comments
Closed

Comments

@GavinPower747
Copy link
Owner

Hello everyone,

For everyone following the development of the api on either the mailing list or the official api discord you'll know that there is a rather large update coming today (03/10/18) the main feature of this is a changing of the PC URL's to include the platforms rather than the region. This means that there are now different URLs for accessing matches on the PC and Xbox and as such there will be a small change in how this library is now called. Rather than the traditional

matchService.GetMatch(PubgRegion.PCEurope, "MatchID");

Which we use today there will now be two different methods, one for PC and one for Xbox and they will be suffixed as such

matchService.GetMatchPC(PubgPlatform.Steam, "matchID");
matchService.GetMatchXbox(PubgRegion.XboxEurope, "MatchID");

This also may take a little bit of time to get into your hands as there will need to be some sort of testing done once the API goes live. Luckily the suite of tests should be enough to run but we don't have clear information on how things like match samples will be affected by this change so there could be a case of some trial or error in the testing phase.

Sorry for any inconvienience this has caused and we'll look to get 2.0.0 into your hands ASAP

@GavinPower747 GavinPower747 changed the title Service Methods Split into PC and Xbox for 2.0.0 and potential delays Service Methods Split into PC and Xbox for 2.0.0 and Potential Delays Oct 3, 2018
@GavinPower747
Copy link
Owner Author

If anyone would like to review the changes and keep up to date on the latest, they can do so at pull request #81

@GavinPower747
Copy link
Owner Author

Based on the information we've been given the work to update is now complete, we just need to wait until the API goes live and then test against it. Assuming all goes well I'll merge to master and build for release

@GavinPower747
Copy link
Owner Author

2.0.0 is currently building at https://ci.appveyor.com/project/GavinPower747/pubg-dotnet/build/2.0.0.161 on completion it will automatically upload to nuget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant