Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Cymbal Front-end Tweaks #614

Closed
1 of 2 tasks
NimJay opened this issue Nov 3, 2021 · 2 comments · Fixed by #1304
Closed
1 of 2 tasks

Additional Cymbal Front-end Tweaks #614

NimJay opened this issue Nov 3, 2021 · 2 comments · Fixed by #1304
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@NimJay
Copy link
Collaborator

NimJay commented Nov 3, 2021 •
edited
Loading

@NimJay NimJay added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Nov 3, 2021
@bourgeoisor
Copy link
Member

@NimJay is this issue still active?

@NimJay NimJay added the good first issue This issue is a good place to started contributing to this repository. label May 10, 2022
@NimJay
Copy link
Collaborator Author

NimJay commented May 10, 2022 •
edited
Loading

@bourgeoisor Thanks for bring my attention to this. :)

This ticket is very low priority.
Next time this ticket reaches out-of-SLO, let's definitely close it.
I'll leave it open for now in case someone wants a fun, easy ticket to work on.
Definitely a good beginner ticket — so I've just added the "good first issue" label.
I'll add screenshots (for anyone without access to the Figma prototypes) of the changes to be made. :)

1. Button States
Screen Shot 2022-05-10 at 9 45 27 AM

This can easily be achieved with the :hover and :active CSS selectors.

2. Logo
Screen Shot 2022-05-10 at 9 54 11 AM

This was referenced Nov 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue This issue is a good place to started contributing to this repository. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vary Cymbal buttons' style based on state GoogleCloudPlatform/microservices-demo
2 participants
@bourgeoisor @NimJay