Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more complete trace example #25

Open
kintel opened this issue Apr 3, 2020 · 4 comments
Open

Add more complete trace example #25

kintel opened this issue Apr 3, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers priority: p3 trace

Comments

@kintel
Copy link

kintel commented Apr 3, 2020

The current trace example is very minimal.
We should add a more complete example that:

  • Is a service
  • Makes an external HTTP request
  • Uses auto-instrumentation to create both server and client spans
  • Uses trace context from incoming HTTP headers
@mayurkale22
Copy link
Contributor

Just so you know: we have a couple of examples in the main OpenTelemetry repo: https://github.com/open-telemetry/opentelemetry-js/tree/master/examples. Maybe, we can point everyone to use those examples, WDYT?

@kintel
Copy link
Author

kintel commented Apr 4, 2020

Yeah, I don't think we need to be exhaustive here, but since none of the upstream examples will work out of the box with Cloud Trace, it would be nice with at least one more complete example here.
The goal would be to provide something that works out of the box to help customers get started.

These examples could live in https://github.com/GoogleCloudPlatform/nodejs-docs-samples, but I'm not 100% certain what examples should go where.

@punya punya added the trace label Feb 1, 2021
@dashpole dashpole added enhancement New feature or request priority: p3 labels Jan 23, 2023
@dashpole
Copy link
Contributor

triaging. It is a good suggestion, but not urgent.

@dashpole dashpole added the good first issue Good for newcomers label Jan 23, 2023
@dashpole
Copy link
Contributor

Still not urgent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority: p3 trace
Projects
None yet
Development

No branches or pull requests

5 participants