Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect from spring-cloud-dependencies-parent #1294

Closed
elefeint opened this issue Oct 14, 2022 · 0 comments · Fixed by #1287
Closed

Disconnect from spring-cloud-dependencies-parent #1294

elefeint opened this issue Oct 14, 2022 · 0 comments · Fixed by #1287

Comments

@elefeint
Copy link
Contributor

spring-cloud-gcp-dependencies still lists spring-cloud-dependencies-parent as its parent. This is a relic from the time when this project was under spring-cloud organization.

There are a couple of things that need to be done:

  1. Remove the <parent> section in the spring-cloud-gcp-dependencies pom.xml. Note that it will no longer have any parent. This is normal (here is libraries BOM as an example).
  2. Look through the spring-cloud-dependencies-parent sections that used to be inherited, and add the correct equivalent to spring-cloud-gcp-dependencies BOM. For example, the license needs to be added (use spring-cloud-gcp root poml.xml and just copy what it has). We don't need any of the profiles; our build does not use these.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants