From 4ba0801a822ffb54a44a5ed9c80d3b4f8cc2cb0e Mon Sep 17 00:00:00 2001 From: Sergio Felix Date: Wed, 21 Jul 2021 12:09:52 -0700 Subject: [PATCH 1/3] Update additional-spring-configuration-metadata to contain missing management.health.pubsub configuration This change adds the missing management endpoint found in the [documentation](https://googlecloudplatform.github.io/spring-cloud-gcp/2.0.3/reference/html/index.html#cloud-pubsub-health-indicator) to the metadata. This will allow IntelliJ to provide proper tooltips and recognize the property by users. Fix: #542 --- .../META-INF/additional-spring-configuration-metadata.json | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json b/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json index 4957d76e3c..7d0cc922f4 100644 --- a/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json +++ b/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json @@ -119,6 +119,12 @@ "type": "java.lang.Boolean", "description": "Auto-configure Google Cloud Core components.", "defaultValue": true + }, + { + "name": "management.health.pubsub", + "type": "java.lang.Boolean", + "description": "The health indicator will verify whether Cloud Pub/Sub is up and accessible by your application.", + "defaultValue": true } ] } From 9f4c36fe609399f76ec90ff8e9b0f683507ed86c Mon Sep 17 00:00:00 2001 From: Sergio Felix Date: Wed, 21 Jul 2021 12:29:58 -0700 Subject: [PATCH 2/3] Update spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json Co-authored-by: Mike Eltsufin --- .../META-INF/additional-spring-configuration-metadata.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json b/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json index 7d0cc922f4..a351037d56 100644 --- a/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json +++ b/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json @@ -121,11 +121,10 @@ "defaultValue": true }, { - "name": "management.health.pubsub", + "name": "management.health.pubsub.enabled", "type": "java.lang.Boolean", "description": "The health indicator will verify whether Cloud Pub/Sub is up and accessible by your application.", "defaultValue": true } ] } - From b226e9299c67fa61aa59d615af731cf018bc07eb Mon Sep 17 00:00:00 2001 From: Sergio Felix Date: Wed, 21 Jul 2021 12:30:03 -0700 Subject: [PATCH 3/3] Update spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json Co-authored-by: Mike Eltsufin --- .../META-INF/additional-spring-configuration-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json b/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json index a351037d56..5303360435 100644 --- a/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json +++ b/spring-cloud-gcp-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json @@ -123,7 +123,7 @@ { "name": "management.health.pubsub.enabled", "type": "java.lang.Boolean", - "description": "The health indicator will verify whether Cloud Pub/Sub is up and accessible by your application.", + "description": "Whether to enable the Pub/Sub health indicator when used with Spring Boot Actuator.", "defaultValue": true } ]