feat: rework .nycrc to support --all #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
JustinBeckwith
added
the
do not merge
JustinBeckwith
suggested changes
Apr 18, 2019
| "src/*{/*,/**/*}.js", | ||
| "src/*/v*/*.js", | ||
| "test/**/*.js", | ||
| "build/test" |
There was a problem hiding this comment.
I notice this doesn't do anything funky with TypeScript. Are we getting coverage from what's in build/src, or from src/? How do we know this isn't being counted twice?
There was a problem hiding this comment.
Coverage uses source-maps, so in reports it will point the user to the files in src/ as the files missing coverage; in practice it’s always the files in build/src that are executed, but will not show up in reports due to them including source-maps.
|
So this LGTM. Just please submit a hammer PR first, then lets land this one. |
JustinBeckwith
approved these changes
Apr 30, 2019
bcoe
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is this?
This reworks our
.nycrcto better support the flag--all; this lets us know we've missed writing coverage for files:Note: this update requires nyc@14.
oddities
I think the rules:
were an attempt to not collect coverage in the
src/v1,src/v3beta1directory, etc."src/*{/*,/**/*}.js",feels a little heavy handed, and was stopping us from collecting coverage for some libraries.src/v1? seems like in a perfect world we'd eventually have tests that exercise these APIs?