-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google-http-client and google-http-client-apache-v2 to 1.31 #1434
Comments
They finally fixed googleapis/google-http-java-client#578. When they release a new version, we can migrate and remove our code to configure proxy credentials from system properties. This branch should already be working. |
Just hit another bug in Google HTTP Client :( googleapis/google-http-java-client#715 Asides, looks like they deprecated |
#1415 upgraded google-http-client to 1.27.0, but a lot of our usage have been marked deprecated with 1.27.0. Unfortunately, due to this bug in 1.27.0, it is not possible to get away from the deprecated usage.
To address all these issues, they made significant changes to 1.28.0. They had to break the Apache adapter into its own artifact google-http-client-apache with two different implementation flavors:
They said the legacy version was necessary for internal usage: googleapis/google-http-java-client#543, googleapis/google-http-java-client#558, googleapis/google-http-java-client#576 (comment)
We may choose to stick with the legacy google-http-client-apache 1.28.0, but I think moving to 2.0.0 is the right thing to do. In any case, I realized there are some complication and annoyance: #1415 (comment), googleapis/google-http-java-client#576 (comment)
Another side effect with google-http-client 1.28.0 is that we need to upgrade Guava to 26.0-jre from the current 23.5-jre.
Lastly, I noticed one very useful and important feature in the modern 2.0.0. Looking at the code, there seems no need to configure proxy auth ourselves (that we did in #1337), as long as we build the Apache
HttpClient
withuseSystemProperties()
. (The defaultHttpClient
built withApacheHttpTransport
turns it on.) Then, it will useSystemDefaultCredentialsProvider
, and looking at the code, it will pick uphttp(x).proxy{User|Password}
. It does look like we can remove ouraddProxyCredentials()
code.(FTR, https://github.com/GoogleContainerTools/jib/compare/remove-deprecated?expand=1 has a not-so-great reference implementation, but has some problem.)
The text was updated successfully, but these errors were encountered: