Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance RegistryClient tests #1808

Open
briandealwis opened this issue Jun 24, 2019 · 2 comments
Open

Enhance RegistryClient tests #1808

briandealwis opened this issue Jun 24, 2019 · 2 comments
Assignees
@louismurerwa
Labels
area/jib-core cleanup priority: p4

Comments

@briandealwis
Copy link
Member

We should have tests around the RegistryClient network requests. Maybe can make TestWebServer take a list of expect-response pairs.

Originally posted by @briandealwis in #1793
@chanseokoh
Copy link
Member

Sounds good. Just don't start working on this now; I have a branch modifying TestWebServer that I was planning to push at some far point in the future, and I think I should push that now.

@chanseokoh chanseokoh mentioned this issue Jun 24, 2019
Merged
@chanseokoh
Copy link
Member

@louismurerwa some tests we can add:

  • RegistryClient.pullManifest()
  • RegistryClient.pushManifest()
  • RegistryClient.checkBlob()
  • RegistryClient.pullBlob()
  • RegistryClient.pushBlob()

@louismurerwa louismurerwa self-assigned this Jun 30, 2020
@louismurerwa louismurerwa mentioned this issue Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louismurerwa louismurerwa

Labels
area/jib-core cleanup priority: p4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@briandealwis @loosebazooka @chanseokoh @meltsufin @louismurerwa