Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Support trigger file #1954

Closed
saturnism opened this issue Apr 12, 2019 · 5 comments
Closed

Feature Request - Support trigger file #1954

saturnism opened this issue Apr 12, 2019 · 5 comments
Labels
area/performance area/watch kind/feature-request priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.

Comments

@saturnism
Copy link

Currently Skaffold triggers rebuild/redeploy on every file change and may be too frequent. Add a mode to rather watching all files, watch only one specified trigger file to kick off rebuid/redeploy.

@nkubala
Copy link
Contributor

nkubala commented Apr 16, 2019

+1 to this, we're discussing different enhancements to the way skaffold triggers builds.

it might make sense to configure this on a per-artifact basis as well, since different artifacts might represent different "areas of the code" which might have separate triggers. this could live in the skaffold.yaml and look something like

build:
  artifacts:
  - image: my_image
    triggerFiles:
    - code.go
    - app.go
  - image: my_java_image
    triggerFiles:
    - app.java

we're also considering adding a way for users to switch to manual trigger mode, which would be exposed through a gRPC/HTTP endpoint. this could also be exposed through a UI element in Cloud Code.

@saturnism
Copy link
Author

more or less, the trigger file may not be a source file at all, but a designated file that can user or IDE can touch

@tejal29
Copy link
Member

tejal29 commented Sep 19, 2019

@saturnism We now have a control api which can trigger a maunal build via curl.
I will close this once #2912.

@balopat balopat added kind/documentation priority/p0 Highest priority. We are actively looking at delivering it. and removed kind/feature-request labels Sep 20, 2019
@tejal29 tejal29 added priority/p1 High impact feature/bug. and removed priority/p0 Highest priority. We are actively looking at delivering it. labels Sep 23, 2019
@saturnism
Copy link
Author

I feel curl/api is a very different use case than a file trigger though. I.e., file based trigger is the most natural/integratabtle w/ existing toolings.

@tstromberg tstromberg added kind/feature-request priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence. and removed kind/documentation priority/p1 High impact feature/bug. labels Apr 21, 2020
@nkubala
Copy link
Contributor

nkubala commented Mar 19, 2021

closing this due to inactivity.

@nkubala nkubala closed this as completed Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance area/watch kind/feature-request priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.
Projects
None yet
Development

No branches or pull requests

6 participants