-
Notifications
You must be signed in to change notification settings - Fork 316
Call client setname on a connection to cluster - currently blocked #327
Comments
It is blocked because of this line redis-py-cluster/rediscluster/client.py Line 52 in d811250
redis-py-cluster/docs/commands.rst Line 87 in b12c353
Basically what you need to find out to implement this command is to know how exactly this command should work. Should it be sent to a specific node, all nodes, based on a slot etc? If you can find that out then i can implement the command properly much faster. |
Hi @Grokzen, OK, I can have a look into this. I'll check how it's done in java library Thanks, |
That sounds like a very good idea |
OK, so this is what I managed to find in RedisAdvancedClusterAsyncCommandsImpl.java - to me it looks like the command is called on all nodes.
As it comes to what a partition is:
Would that be enough for you? Thanks, |
Yes i think that should be easily replicated so the next release could include that fix. |
Awesome, thanks. Best regards, |
I don't have a planned date for it. Last release was very slow and drawn out to get done for me. I hope to pick up the pace and get more fixes and new versions supported much faster then what 2.0.0 was. |
OK, I understand. And is there a chance this fix is going to get into the repository soon so I can apply it and test? Thanks, |
FYI I managed to get what I want just by extending
Thing is, you've got to set this client name on all connections whenever they open. BR, |
Yeah, that looks like a hack that works for now, but yeah, you dont really want to make your own connection class really, but if it solves it for you now, then go for it. What is the use-case for using |
So, I'm introducing Redis into an existing application now and am trying to analyze a big number of open connections to Redis. I'm happy to upgrade to a newer version once the functionality is delivered, but for now I would like to start my analysing without waiting. BTW Do you plan to set the client name for each new connection? Thanks, |
I dont know really. I would have to dig deeper into what the java lib is doing, but my guess is that i will just replicate whatever redis-py is doing and then just fanout it to all nodes. More then that i dont know now. |
OK, sure thing. |
@MrUKI If you can show that this feature is something that is implemented inside redis-py but not working in this lib then i will fix it. Otherwise this sounds like a feature that should be included in the upstream repo first so it will then propegate down to this lib in a updated version of redis-py-cluster. If this would be a cluster onlly feature that you found inside lettuce then i will consider it, otherwise you have to propse it to the upstream package. |
Hi,
I would like to
client setname
on connections to redis cluster using your library, but unfortunately they are in a 'blocked' list of commands, what prevents me from doing it.Are you able to suggest if there's any way to achieve it using your library?
Thanks in advance,
Konrad
The text was updated successfully, but these errors were encountered: