Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

Allow not writing initialize#arguments property in service.vvisp.json #35

Open
JhChoy opened this issue Dec 31, 2018 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JhChoy
Copy link
Contributor

JhChoy commented Dec 31, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

If we describe service.vvisp.json like:

  "ContractA": {
      "path": "path/to/your/Contract.sol",
      "initialize": {
        "functionName": "initialize"
      }
    }

It makes error! So we have to describe like:

  "ContractA": {
      "path": "path/to/your/Contract.sol",
      "initialize": {
        "functionName": "initialize",
        "arguments": []
      }
    }

Expected behavior

Allow the first describe.

Environment


vvisp version: v0.1.9


Environment:
- Node version: v8.11.2
- Operating system: Mac OSX
@JhChoy JhChoy added enhancement New feature or request good first issue Good for newcomers labels Dec 31, 2018
@JhChoy JhChoy changed the title Allow not to write initialize#arguments property in service.vvisp.json Allow not writing initialize#arguments property in service.vvisp.json Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant