From e6ec2661b73de1a3cfd184e37bf02bf9cd2e9c24 Mon Sep 17 00:00:00 2001 From: William Roberts Date: Wed, 19 Apr 2017 16:12:09 -0700 Subject: [PATCH] init: fix errno handling on KillProcessGroup KillProcessGroup can return -1 without errno set, which produces error messages like this: init: Sending signal 15 to service 'vold' (pid 1806) process group... init: failed to kill 2 processes for processgroup 1806 init: killProcessGroup(0, 1806, 15) failed: Success Test: boot and reboot hikey. Change-Id: I51f242da234daee84795a3fbdffe9ad1f4567140 Signed-off-by: William Roberts --- init/service.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/service.cpp b/init/service.cpp index caf5785e52e3..c0745e3404c1 100644 --- a/init/service.cpp +++ b/init/service.cpp @@ -217,7 +217,7 @@ void Service::KillProcessGroup(int signal) { r = killProcessGroup(uid_, pid_, signal); } if (r == -1) { - PLOG(ERROR) << "killProcessGroup(" << uid_ << ", " << pid_ << ", " << signal << ") failed"; + LOG(ERROR) << "killProcessGroup(" << uid_ << ", " << pid_ << ", " << signal << ") failed"; } if (kill(-pid_, signal) == -1) { PLOG(ERROR) << "kill(" << pid_ << ", " << signal << ") failed";