Add tvOS target #71
Merged
Add tvOS target #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lkzhao
requested changes
Feb 7, 2017
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| import UIKit | |||
|
|
|||
| #if os(iOS) | |||
There was a problem hiding this comment.
Try using @available(tvOS, unavailable). Not sure if this works, but looks better this way.
| @@ -30,6 +30,7 @@ protocol HeroDebugViewDelegate { | |||
| func onDone() | |||
| } | |||
|
|
|||
| #if os(iOS) | |||
| @@ -134,7 +134,9 @@ extension HeroContext { | |||
| } else if let barView = view as? UINavigationBar, barView.isTranslucent { | |||
There was a problem hiding this comment.
Not sure how tvOS's navigation bar works. But i think we should not go in to this else if statement. The navigationBar snapshot used here is pretty dependent on iOS's navigation bar implementation. Lets limit this else if to be only available on iOS
|
I will merge now before I do any works to cause conflicts. Thank you! |
|
Alright! If you still want any changes let me know :) |
lkzhao
pushed a commit
that referenced
this pull request
Feb 16, 2017
* Minimal working tvOS project * Don't compile HeroDebugPlugin and HeroDebugView for tvOS target
lkzhao
pushed a commit
that referenced
this pull request
Feb 16, 2017
* Minimal working tvOS project * Don't compile HeroDebugPlugin and HeroDebugView for tvOS target
lkzhao
pushed a commit
that referenced
this pull request
Jun 14, 2017
* Minimal working tvOS project * Don't compile HeroDebugPlugin and HeroDebugView for tvOS target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tvOS target.
Made HeroDebugPlugin and HeroDebugView unavailable until UISlider functionality is replaced with continuous gesture.