Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing an option's default or existence can trigger repouring the bottle unnecessarily #1399

Closed
ilovezfs opened this issue Oct 29, 2016 · 1 comment
Assignees

Comments

@ilovezfs
Copy link
Contributor

A source build may be triggered when it's unwanted or unneeded if

  • an install receipt (using the option) is present that was created when the option default was different
    or
  • another formula's depends_on "foo" => "with-bar" was authored when the option default was different

Typically the option "with-bar" has been replaced by "without-bar" or by nothing (because it's now always on, always off, no longer applicable, or now hidden behind a build.with? or build.without?).

A related issue is that there's no mechanism in the DSL to specify a default-on option is mandatory, so simply making a stale "with-bar" into a no-op (rather than an unneeded source build) is still pretty bad because it gives the impression that "bar" is being mandated, but "surprisingly" a keg in the Cellar built "without-bar" (a real, current formula option) would satisfy a no-op "with-bar" in depends_on "foo" => "with-bar".

@ilovezfs
Copy link
Contributor Author

Based on what was reported in Homebrew/homebrew-core#7753 it seems this is still happening with dependency build options since depends_on "llvm" => "with-nosuchoption" behaves differently from depends_on "llvm".

@ilovezfs ilovezfs reopened this Dec 10, 2016
@ilovezfs ilovezfs changed the title Changing an option's default or existence can trigger unnecessary source builds Changing an option's default or existence can trigger repouring the bottle unnecessarily Dec 10, 2016
@ghost ghost added the in progress Maintainers are working on this label Dec 10, 2016
@ghost ghost removed the in progress Maintainers are working on this label Dec 10, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants