Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject the CONNECT method in Styx Proxy. #312

Closed
dvlato opened this issue Oct 12, 2018 · 0 comments
Closed

Reject the CONNECT method in Styx Proxy. #312

dvlato opened this issue Oct 12, 2018 · 0 comments
Assignees
@dvlato
Labels
bug help wanted styx-0.7

Comments

@dvlato
Copy link
Contributor

dvlato commented Oct 12, 2018

The problem

HTTP requests using the CONNECT method should be rejected by Styx proxy with a 405 Method not allowed response code.

Detailed description

Styx proxy does not currently provide any support for CONNECT requests so requests with that method should be rejected (with the 405). The current faulty behaviour is that Styx accepts the requests but fails to process it, generating a 500 server side error.

The status of support for TCP tunneling via the HTTP Connect method is tracked in #311.

Acceptance criteria

The proxy will return a 405 error on reception of a HTTP Request using the CONNECT method.
@dvlato dvlato self-assigned this Oct 25, 2018
dvlato pushed a commit to dvlato/styx that referenced this issue Oct 25, 2018
@a-dlatorre
ExpediaGroup#312 Reject requests using the CONNECT method.
e4f733a
dvlato added a commit that referenced this issue Oct 29, 2018
@dvlato
Backport to 0.7 - Reject requests using the CONNECT method ( Fixes #312…
8dc8795 
…) (#331)

* #312 Reject requests using the CONNECT method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvlato dvlato

Labels
bug help wanted styx-0.7
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvlato