Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'asCompletableFuture' method from Styx Eventual. #346

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

mikkokar
Copy link
Contributor

@mikkokar mikkokar commented Nov 16, 2018

Removes asCompletableFuture from Eventual. It feels quite pointless now as the Eventual implements a Reactive Streams Publisher interface.

In unit tests it is often useful to block and wait for response. Use Mono from Reactor-core instead:

HttpRequest full = Mono.from(streamingRequest.aggregate(ONE_MEGABYTE)).block();

Use Mono to convert to CompletableFuture:

Mono.from(response1.aggregate(1000)).toFuture();

@mikkokar mikkokar merged commit 37ff787 into ExpediaGroup:master Nov 21, 2018
@mikkokar mikkokar deleted the remove-as-completable-future branch November 21, 2018 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants