Remove 'asCompletableFuture' method from Styx Eventual. #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
asCompletableFuture
from Eventual. It feels quite pointless now as theEventual
implements a Reactive StreamsPublisher
interface.In unit tests it is often useful to block and wait for response. Use
Mono
from Reactor-core instead:Use
Mono
to convert toCompletableFuture
: