Create a docker image from an official Styx release. #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
reviewed
Dec 21, 2018
| && mv ${BASENAME} styx \ | ||
| && rm styx.zip | ||
|
|
||
| EXPOSE 8080 8443 9000 |
There was a problem hiding this comment.
As a future enhancement, we might want to expose the JMX port as well (it's not exposed in the init script).
dvlato
reviewed
Dec 24, 2018
| @@ -0,0 +1,12 @@ | |||
| # See origins/origins-default.yaml for explanation of config format | |||
| --- | |||
| - id: "app" | |||
There was a problem hiding this comment.
We are missing some instructions on how to use and configure the Docker image.
dvlato
reviewed
Dec 24, 2018
docker/styx-env.sh
Outdated
| # Set Netty leak detection level | ||
| # JAVA_OPTS="$JAVA_OPTS -Dio.netty.leakDetectionLevel=advanced" | ||
|
|
||
| # Enable remote debugging |
There was a problem hiding this comment.
Remove commented out config which doesn't need to be documented.
dvlato
approved these changes
Dec 24, 2018
…ory. Add information about building and using the Styx Docker image.
…ublic-docker-image
dvlato
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "public" docker image built from an official Styx release. We could add this to a hub.docker.com. Going forward the docker build should be automated as a part of release process. Also there is a separate docker file for the development version. But hey, this is the first step!
Also need to think if a separate repository is better for the public docker file.
Build instructions:
$ cd docker$ docker build -t styx .