Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused properties in Server config #428

Closed
kvosper opened this issue Jun 10, 2019 · 4 comments
Closed

Unused properties in Server config #428

kvosper opened this issue Jun 10, 2019 · 4 comments
Assignees
@manishsahni2000

Comments

@kvosper
Copy link
Contributor

kvosper commented Jun 10, 2019

The problem

Several properties exist in the NettyServerConfig that are not used anywhere. These could be deprecated, or the configurability may have been accidentally removed.

Detailed description

These ones are not used:

  • tcpNoDelay
  • nioReuseAddress
  • nioKeepAlive
  • maxContentLength

Acceptance criteria

  • Reintroduce configurability where needed
  • Remove any properties not needed
@manishsahni2000
Copy link
Contributor

manishsahni2000 commented Sep 29, 2019 •
edited
Loading

Hi ,

I have created a PR for this, Please review and let me know @kvosper @mikkokar

manishsahni2000 pushed a commit to manishsahni2000/styx that referenced this issue Sep 29, 2019
ExpediaGroup#428 Removing Unused properties in Server config
617f938
@mikkokar
Copy link
Contributor

Thank you @manishsahni2000! I will have a look.

@mikkokar
Copy link
Contributor

PR is #464.

mikkokar pushed a commit that referenced this issue Oct 2, 2019
@manishsahni2000 @mikkokar
Fix issue #428: Removing Unused properties in Server config (#464)
b5e330a
@mikkokar
Copy link
Contributor

mikkokar commented Oct 4, 2019

Fixed & merged.

@mikkokar mikkokar closed this as completed Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manishsahni2000 manishsahni2000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@manishsahni2000 @mikkokar @kvosper