Load Balancing Group routing object #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
reviewed
Jun 11, 2019
components/proxy/src/main/java/com/hotels/styx/routing/RoutingObjectAdapter.java
Outdated
Show resolved
Hide resolved
dvlato
reviewed
Jun 11, 2019
components/proxy/src/main/java/com/hotels/styx/routing/handlers/HostProxy.java
Outdated
Show resolved
Hide resolved
dvlato
reviewed
Jun 11, 2019
components/proxy/src/main/java/com/hotels/styx/routing/handlers/HostProxy.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/routing/handlers/HostProxy.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/routing/handlers/HostProxy.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/routing/handlers/HostProxy.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/routing/handlers/LoadBalancingGroup.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/startup/StyxServerComponents.java
Outdated
Show resolved
Hide resolved
kvosper
suggested changes
Jun 11, 2019
| * | ||
| * @return a collection of all entries. | ||
| */ | ||
| Collection<Map.Entry<String, T>> entrySet(); |
There was a problem hiding this comment.
Should we consider using com.hotels.styx.common.Pair instead of Map.Entry?
There was a problem hiding this comment.
Possibly. Can you think of any pros/cons using Pair vs Map.Entry?
There was a problem hiding this comment.
Map.Entry does have a method setValue(V value) for mutating it (or throwing UnsupportedOperationException), which could give the illusion of mutability, however most Java programmers will be aware of the awkward way that the JCF handles immutable classes.
Otherwise, it doesn't really make a difference, so if Map.Entry is more convenient otherwise, I think we can put up with it.
components/common/src/main/java/com/hotels/styx/api/ResponseEventListener.java
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/routing/RoutingObjectAdapter.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/routing/handlers/HostProxy.java
Outdated
Show resolved
Hide resolved
mikkokar
force-pushed
the
application-router
branch
from
04189e5
to
3040730
Compare
kvosper
suggested changes
Jun 13, 2019
components/proxy/src/main/kotlin/com/hotels/styx/routing/RoutingObjectRecord.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/routing/handlers/LoadBalancingGroup.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/routing/handlers/LoadBalancingGroup.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/test/kotlin/com/hotels/styx/routing/handlers/LoadBalancingGroupTest.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/test/kotlin/com/hotels/styx/routing/handlers/LoadBalancingGroupTest.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/test/kotlin/com/hotels/styx/routing/handlers/LoadBalancingGroupTest.kt
Outdated
Show resolved
Hide resolved
system-tests/ft-suite/src/test/kotlin/com/hotels/styx/routing/LoadBalancingGroupSpec.kt
Outdated
Show resolved
Hide resolved
system-tests/ft-suite/src/test/kotlin/com/hotels/styx/routing/LoadBalancingGroupSpec.kt
Outdated
Show resolved
Hide resolved
dvlato
approved these changes
Jun 17, 2019
dvlato
reviewed
Jun 20, 2019
| import java.nio.charset.StandardCharsets.UTF_8 | ||
| import java.util.concurrent.CompletableFuture | ||
|
|
||
| fun routingObjectDef(text: String) = YamlConfig(text).`as`((RoutingObjectDefinition::class.java)) | ||
|
|
||
| data class RoutingContext( | ||
| internal data class RoutingObjectFactoryContext( |
There was a problem hiding this comment.
It's probably not too clear from its usage (import com.hotels.styx.routing.RoutingObjectFactoryContext, etc.) that this is a test class with default values. Maybe we could choose a different name,
Add RoutingObjectAdapter for providing load balancing metric. Add `entrySet` method to ObjectStore. Add `whenFinished` action to ResponseEventListener. Add functional test suite for LoadBalancingGroup. LoadBalancingGroup: Add functional tests for sticky sessions and origins restriction cookie.
Rename HttpHandlerFactory class to RoutingObjectFactory. Kotlin: RoutingObjectFactoryContext. Rename to Builtins.
mikkokar
force-pushed
the
application-router
branch
from
a3faffb
to
6eb8d08
Compare
kvosper
approved these changes
Jun 28, 2019
dvlato
pushed a commit
that referenced
this pull request
Jul 3, 2019
* Add LoadBalancingGroup routing object. * Add RoutingObjectDecorator to provide a load balancing metric. * Add `entrySet` method to ObjectStore. * Add `whenFinished` action to ResponseEventListener. * Rename HttpHandlerFactory class to RoutingObjectFactory. * Remove safe calls from Kotlin tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
LoadBalancingGrouprouting object that balances load between other routing objects. Specifically it can load balance betweenHostProxyobjects, and can be used withPathPrefixRouterto perform styx application routing. Currently, onlyPow2load balancing algorithm is supported.