Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve origins reload visibility #108

Merged
merged 5 commits into from
Mar 13, 2018
Merged

Improve origins reload visibility #108

merged 5 commits into from
Mar 13, 2018

Conversation

mikkokar
Copy link
Contributor

Improve logging messages when the origins file is reloaded:

  • md5 code of the loaded file
  • modification time of the loaded file
  • The cause of the reload: Initial load, admin interface request, or automatically detected change.

@mikkokar
Remove onError method from the Registry.ChangeListener. This is bec…
cd591c3 
…ause

`onError` does not notify about changes.

Add md5-hash into FileBackedRegistry outcome messages.

Set `FileChangeMonitor` logger to INFO in some logback configuration files.
@mikkokar
Add reload outcome logging in FileBackedBackendServicesRegistry.
6472001
@mikkokar
Prevent Styx from starting when initial origins configuration fails t…
f72ea1d 
…o load.

Origins reload command to return 500 Internal Server Error (as opposed to 400 Bad Request)
when the origins file failed to reload.
@mikkokar
Add timestamp into origins configuration reload outcome messages.
4e3ec2e
@mikkokar
Stop monitor after the unit test.
82da649
@dvlato dvlato merged commit 0f4d68f into ExpediaGroup:master Mar 13, 2018
@kvosper kvosper mentioned this pull request Apr 18, 2018
Merged
@mikkokar mikkokar deleted the origins-reload-admin-interface branch April 1, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvlato dvlato dvlato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikkokar @dvlato