Fix for NPE in case of retry. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of retry RetryOnErrorHandler was recreated without required fields. Additionally this change contains refactoring to reuse OriginStatsFactory in StyxHttpClient.
mikkokar
suggested changes
Jan 25, 2018
|
|
||
| RetryPolicy.Context context = mock(RetryPolicy.Context.class); | ||
| ConnectionPool connectionPool = mock(ConnectionPool.class); | ||
| LoadBalancingStrategy.Context lbContext = mock(LoadBalancingStrategy.Context.class); |
There was a problem hiding this comment.
The mock setup adds lots of verbosity in the tests in this class. Please consider:
- adding a helper method to set up context
- convert the mocks like
connectionPool,lbContext,loadBalancingStrategyinto fields and initialise in test setup method before each test.
kvosper
suggested changes
Jan 25, 2018
| } | ||
|
|
||
| @Test | ||
| public void shouldRetry() { |
There was a problem hiding this comment.
This test name is not informative. We need to make the cause+effect clear.
| } | ||
|
|
||
| @Test | ||
| public void shouldNotRetryBasedOnWrongException() { |
There was a problem hiding this comment.
What makes an exception wrong? I think the test name should mention the marker interface.
kvosper
approved these changes
Jan 25, 2018
mikkokar
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of retry RetryOnErrorHandler was recreated without required fields.
Additionally this change contains refactoring to reuse OriginStatsFactory in
StyxHttpClient.