Refactor builders: NettyConnectionFactory #81
Conversation
| @@ -1,12 +1,12 @@ | |||
| /** | |||
| * Copyright (C) 2013-2018 Expedia Inc. | |||
| * | |||
| * <p> | |||
There was a problem hiding this comment.
Get rid of these <p>s - they cause the copyright notice to get added again when you build.
There was a problem hiding this comment.
OMG why do they keep appearing all the time? Must be an IntelliJ Idea setting somewhere.
| this.httpRequestOperationFactory = requireNonNull(builder.httpRequestOperationFactory); | ||
| } | ||
|
|
||
| private static ClientEventLoopFactory eventLoopFactory(String name, int threadCount) { |
There was a problem hiding this comment.
This method seems a little redundant. If the class name is too long, perhaps we can change it? Or create a static-factory method.
|
|
||
| /** | ||
| * Sets the name. | ||
| * | ||
| * @param name name | ||
| * @return this builder | ||
| * @return this Netty |
| @@ -160,7 +146,7 @@ public Builder name(String name) { | |||
| * Sets number of client worker threads. | |||
| * | |||
| * @param clientWorkerThreadsCount number of client worker threads | |||
| * @return this builder | |||
| * @return this NettyConnectionFactory.Builder | |||
There was a problem hiding this comment.
Are these changes strictly necessary (see 2 similar changes below)? They are just brief descriptions of return value and don't really need the full class name IMO.
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| * Copyright (C) 2013-2018 Expedia Inc. |
There was a problem hiding this comment.
Is this caused by the formatter? We want to make sure it matches what the copyright notice generator adds or it will add it again.
| @@ -1,12 +1,12 @@ | |||
| /** | |||
| * Copyright (C) 2013-2018 Expedia Inc. | |||
| * | |||
| * <p> | |||
Simplifies NettyConnectionFactory object construction.