From d2aa897839300883a1082940376a08f82360f27e Mon Sep 17 00:00:00 2001 From: Ronald Brill Date: Wed, 16 Oct 2024 07:28:36 +0200 Subject: [PATCH] i see no reason for this list to refresh the cache on attribute changes - let's try without --- .../htmlunit/html/AbstractDomNodeList.java | 31 +------------------ 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/src/main/java/org/htmlunit/html/AbstractDomNodeList.java b/src/main/java/org/htmlunit/html/AbstractDomNodeList.java index 5f1cafdefa..80ea34944b 100644 --- a/src/main/java/org/htmlunit/html/AbstractDomNodeList.java +++ b/src/main/java/org/htmlunit/html/AbstractDomNodeList.java @@ -56,10 +56,6 @@ public AbstractDomNodeList(final DomNode node) { final DomHtmlAttributeChangeListenerImpl listener = new DomHtmlAttributeChangeListenerImpl(this); node_.addDomChangeListener(listener); - if (node_ instanceof HtmlElement) { - ((HtmlElement) node_).addHtmlAttributeChangeListener(listener); - cachedElements_ = null; - } } /** @@ -132,8 +128,7 @@ public E get(final int index) { /** * DOM change listener which clears the node cache when necessary. */ - private static final class DomHtmlAttributeChangeListenerImpl - implements DomChangeListener, HtmlAttributeChangeListener { + private static final class DomHtmlAttributeChangeListenerImpl implements DomChangeListener { private final transient WeakReference> nodeList_; @@ -159,30 +154,6 @@ public void nodeDeleted(final DomChangeEvent event) { clearCache(); } - /** - * {@inheritDoc} - */ - @Override - public void attributeAdded(final HtmlAttributeChangeEvent event) { - clearCache(); - } - - /** - * {@inheritDoc} - */ - @Override - public void attributeRemoved(final HtmlAttributeChangeEvent event) { - clearCache(); - } - - /** - * {@inheritDoc} - */ - @Override - public void attributeReplaced(final HtmlAttributeChangeEvent event) { - clearCache(); - } - private void clearCache() { if (nodeList_ != null) { final AbstractDomNodeList nodes = nodeList_.get();