Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do end to end testing of add new primary bundles #635

Open
justincc opened this issue Nov 22, 2019 · 3 comments
Open

Do end to end testing of add new primary bundles #635

justincc opened this issue Nov 22, 2019 · 3 comments
Assignees

Comments

@justincc
Copy link
Contributor

justincc commented Nov 22, 2019

See https://docs.google.com/document/d/19CHvdfnzfJB8NtSnH007BNJBlJGXBeGm8wioCIDUg-c/edit#heading=h.xhiy2zjppg2l

Acceptance criteria

  • Adding new primary bundles works through the UI
  • There is an end to end integration test for adding new primary bundles
@justincc justincc added this to the Q4 2019 Milestone 3 milestone Nov 22, 2019
@justincc justincc changed the title Do end to end testing of add new bundles Do end to end testing of add new primary bundles Nov 25, 2019
@justincc
Copy link
Contributor Author

justincc commented Dec 2, 2019

@aaclan-ebi Please let me know once you've run the manual test of adding bundles that refer to an existing in-project entity.

@aaclan-ebi
Copy link
Collaborator

aaclan-ebi commented Dec 2, 2019

Manual Testing:

Steps

Upload spreadsheet 1

spreadsheet 1: https://app.zenhub.com/files/132741306/e1858b3d-84ab-4810-b5e0-14aeeff38ca5/download

submission 1: https://ui.ingest.dev.data.humancellatlas.org/submissions/detail?uuid=b2b48821-b472-4f32-8c73-6da9455b18b6

Bundle 1: https://dss.dev.data.humancellatlas.org/v1/bundles/b01ba8a1-1d87-441f-9680-59fc6b806d41/?replica=aws&version2019-12-02T133903.019135Z

Upload spreadsheet 2

Specify linking by using uuids created from submission 1
spreadsheet 2: https://app.zenhub.com/files/132741306/2ab56331-166d-4234-86f6-175bc78f1307/download

submission 2: https://ui.ingest.dev.data.humancellatlas.org/submissions/detail?uuid=f28f1006-d631-4181-9826-0fddbda13fa8

Summary of linking done in second spreadsheet:

  • New specimen is linked to existing donor, existing collection protocol
  • New cell suspension is linked to new specimen using existing collection protocol
  • Processes are linking to existing project and existing protocols
  • Files are linked to existing seq protocol and existing lib prep protocol

Bundle 2: https://dss.dev.data.humancellatlas.org/v1/bundles/4b3cb87c-adcf-44d5-8c9f-3e095da1bc37/?replica=aws&version2019-12-02T134355.134159Z

Project view:
https://ui.ingest.dev.data.humancellatlas.org/projects/detail?uuid=095d25bb-1a67-4e3d-8539-9de5fdc978a1

Findings:

  1. Links are done in Ingest successfully
  2. New bundles was exported successfully.
  3. While inspecting the new bundle's files, it seems that it contains existing entities with same uuid but newer version. Ticket filed for this: https://app.zenhub.com/workspaces/ingest-dev-5cfe1cb26482e537cf35e8d1/issues/humancellatlas/ingest-central/647

@aaclan-ebi
Copy link
Collaborator

aaclan-ebi commented Dec 2, 2019

Other findings/comments:

  1. [Important] How do we link update submission to the project?
  1. It's VERY hard to view the linking of entities in Ingest before doing the export.
  2. Need delete project functionality, in case the project is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants