FIXED: CPU shows UNKNOWN

[MonoHue]

Function get_cpu_info() in Package cpuinfo returns a dict that CPU model is indexed by "brand_raw" instead of "brand", see L210 in sacred/hostinfo.py .

[thequilo]

Hi @MonoHue! Thank you! Do you know when that changed or if this breaks in some environments? I'm pretty sure the "brand" key worked a while back. What is the difference between "brand" and "brand_raw"?

[MonoHue]

Hi @MonoHue! Thank you! Do you know when that changed or if this breaks in some environments? I'm pretty sure the "brand" key worked a while back. What is the difference between "brand" and "brand_raw"?

Hi thequilo!

It's true that the field was called "Brand". On Apr 5, 2019, py-cpuinfo rename "Brand" to "Brand_raw" (See workhorsy/py-cpuinfo@419e82e). In fact, there have been many fields renamed, you can check those out at cpuinfo.py.

Setting a fallback for compatibility is great too.

Regards

[thequilo]

Thanks for the clarification. Since the key change happened three years ago I guess it's fine to just use the "brand_raw" key and drop "brand" (as it is currently implemented in the PR).