Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash escaping in BCQL #511

Closed
jan-niestadt opened this issue Apr 16, 2024 · 1 comment
Closed

Slash escaping in BCQL #511

jan-niestadt opened this issue Apr 16, 2024 · 1 comment
Assignees
Milestone

Comments

@jan-niestadt
Copy link
Member

How slash escaping works seems to have accidentally changed in the dev branch. On older BlackLab versions, this will find a single open bracket:

[word="\("]

On the dev branch, you need to use two slashes:

[word="\\("]

Presumably this is because both the BCQL parser and Lucene's regex parser interpret \ as an escape character and take the next character to be literal, both removing one escape character.

We should decide how this should work (the top one probably, seems more intuitive for users and used to work that way).

@jan-niestadt jan-niestadt added this to the v4.0 milestone Apr 16, 2024
@jan-niestadt jan-niestadt self-assigned this Apr 16, 2024
@jan-niestadt
Copy link
Member Author

Fixed in c67789d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant