Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access level (public -> private) of context (DefaultJavaPrettyPrinter.java) #2393

Closed
zielint0 opened this issue Aug 19, 2018 · 3 comments
Labels

Comments

@zielint0
Copy link
Contributor

Change access level from public to private in
src/main/java/spoon/reflect/visitor/DefaultJavaPrettyPrinter.java

        /**
	 * The printing context.
	 *
	 * @deprecated since Spoon 7.1.0, please use {{@link #getContext()}}
	 */
	@Deprecated
	public PrintingContext context = new PrintingContext();

(to access a context, one uses getContext())

The purpose of this issue is to remember of changing access of context.
Related PR: refactor: fix SonarQube - make field 'private', use accessor #2387

@surli
Copy link
Collaborator

surli commented Aug 20, 2018

I let the issue open for now, but FYI before releasing Spoon we always check the deprecated annotation to fix them if it's deprecated since more than one release.
So it will be necessarily done during this process.

@surli surli added the chore label Aug 20, 2018
@zielint0
Copy link
Contributor Author

@surli
Thank you for explanation. I was not sure about release process so created this issue.

@pvojtechovsky
Copy link
Collaborator

The DJPP#context is now private. Issue was solved by #2649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants