Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up.sh always rebuilds images and container #2

Open
christophziegler opened this issue Feb 23, 2021 · 0 comments
Open

up.sh always rebuilds images and container #2

christophziegler opened this issue Feb 23, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@christophziegler
Copy link
Contributor

Regardless of whether news has been loaded from the git repository or not, the script rebuilds all images and containers. This can lead to unintended behavior, if for example state info may get lost if not stored in docker volumes or State API.

The script should therefore check if the local repo is behind or diverged and git pull should be run, e.g. via git status -uno or using the solution presented in this thread. Containers and images should only be rebuild if pull has been run.

A workaround is to run docker-compose up instead of up.sh if the platform shall only be restarted and container rebuild is not nessecary.

@christophziegler christophziegler added the bug Something isn't working label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant