Skip to content
This repository has been archived by the owner on Sep 18, 2019. It is now read-only.

dinghy shouldn't convert to lowercase the URLs #4

Closed
clopez opened this issue Mar 9, 2018 · 1 comment
Closed

dinghy shouldn't convert to lowercase the URLs #4

clopez opened this issue Mar 9, 2018 · 1 comment
Assignees
Labels

Comments

@clopez
Copy link

clopez commented Mar 9, 2018

Commit a3d726f broke URL loading when the URL contains uppercase letters.

When I try to open https://people.igalia.com/clopez/webBenchmarks/JetStream/JetStream-1.1/index.html with dinghy it tries to open https://people.igalia.com/clopez/webbenchmarks/jetstream/jetstream-1.1/index.html (everything lowercase), which fails with 404 as expected-

@aperezdc aperezdc self-assigned this Mar 9, 2018
@aperezdc aperezdc added the bug label Mar 9, 2018
@aperezdc
Copy link
Member

aperezdc commented Mar 9, 2018

Indeed the problem was introduced in a3d726f as you have found out. The string is lowercased to check for the http:// and https:// prefixes always in lowercase and the lowercase string should have been used only for that. I'll make a fix for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants