Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message "pack doesn't have DH sup" is unreadable #2281

Closed
NatoBoram opened this issue Mar 25, 2024 · 1 comment
Closed

Error message "pack doesn't have DH sup" is unreadable #2281

NatoBoram opened this issue Mar 25, 2024 · 1 comment
Labels
bug Something is implemented incorrectly

Comments

@NatoBoram
Copy link

NatoBoram commented Mar 25, 2024

What happened?

What happened

The error message "pack doesn't have DH sup" is unreadable.

What should happen

The error message should be in the chat so we can read it

Steps

  1. Install a shaderspack that doesn't support Distant Horizons
  2. Open a game

Screenshots

image

Log output

pack doesn't have DH sup
orizons (DH) chunks won't shot up. This isn't a bug, get another

Minecraft Version

1.20.1

Iris Version

iris-1.7.0-snapshot+mc1.20.1-7edecd1.jar

Operating System

Pop!_OS 22.04 LTS x86_64

What is your GPU?

AMD ATI Radeon RX 6700 XT

Additional context

  • According to @cola98765 here, the error message is caused by Iris instead of Distant Horizons.
  • It seems like this is a warning instead of an error. The text should probably be yellow to indicate that it's a normal and supported behaviour and not a bug.
  • Sometimes, one may want to switch between DH packs and non-DH packs. One reason for this is that there's no good DH shaderspack yet, so switching between Bliss+DH/Shrimple+DH and Complementary is kind of a necessity if you want to see what you're doing but still have shaders. Having the message take the entire screen for 10 seconds in a bit inconvenient.
@NatoBoram NatoBoram added the bug Something is implemented incorrectly label Mar 25, 2024
@IMS212
Copy link
Member

IMS212 commented Apr 2, 2024

This message is exclusive to the beta, and will not exist in the final release.

@IMS212 IMS212 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is implemented incorrectly
Projects
None yet
Development

No branches or pull requests

2 participants