Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.bablerc in npm package #1

Closed
cymen opened this issue Aug 26, 2016 · 1 comment
Closed

.bablerc in npm package #1

cymen opened this issue Aug 26, 2016 · 1 comment
Labels
bug

Comments

@cymen
Copy link
Contributor

cymen commented Aug 26, 2016

I'm trying to use this with react-native and ran into it trying to run the .bablerc file from within node_modules. It blows up because of the plugin not being present. Apparently, the convention is becoming not to ship the .bablerc in the npm package by adding it to .npmignore.

facebook/react-native#4062

Are you onboard with that?
@cymen cymen mentioned this issue Aug 26, 2016
Merged
@JFusco
Copy link
Owner

JFusco commented Sep 11, 2016 •
edited
Loading

I'm on board with that, we can just add it to the webpack config.

Thanks for the PR - all merged! Sorry it took me a while. Merged in to v1.5.2

@JFusco JFusco closed this as completed in #2 Sep 11, 2016
@JFusco JFusco added the bug label Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cymen @JFusco