Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation Specific Features #38

Open
Sparky983 opened this issue Nov 29, 2022 · 2 comments
Open

Implementation Specific Features #38

Sparky983 opened this issue Nov 29, 2022 · 2 comments
Assignees
Labels
api Something that relates to the public API discord Specific to any discord (discord4j) implementation implementation Something that relates to the implementation paper Specific to the paper implementation
Milestone

Comments

@Sparky983
Copy link
Contributor

Sparky983 commented Nov 29, 2022

With the current architecture of enchanted-shared, it's gonna be pretty challenging for implementations to add their own things. There are currently a few issues addressing some of these problems:

There are also some issues that require a better way for implementations to interact with the shared-enchanted module to allow for other non-user facing implementation specific things:

@Sparky983 Sparky983 added implementation Something that relates to the implementation api Something that relates to the public API paper Specific to the paper implementation discord Specific to any discord (discord4j) implementation labels Nov 29, 2022
@Sparky983 Sparky983 self-assigned this Nov 29, 2022
@Sparky983
Copy link
Contributor Author

Forgot to mention, but this issue is for tracking the API of enchanted-shared to allow for implementation-specific features.

Hopefully, this can be completed by 1.0.0, but this issue is pretty abstract so the line of completion is pretty fuzzy.

@Sparky983 Sparky983 added this to the 1.0.0 milestone Nov 29, 2022
@Sparky983
Copy link
Contributor Author

Sparky983 commented Nov 29, 2022

I'm thinking, so implementations can provide their own specific features we could make enchanted-shared just a regular implementation, and all other ones (enchanted-bukkit, enchanted-d4j) to decorate enchanted-shared.

Quick note - enchanted-shared will not be user-facing, so no compatibility will be guaranteed. We may also decide to mark it as @ApiStatus.Experimental because it will have to be published so maven can find it. It might also be useful so others can easily create their own implementations.

I'm also going to start calling platforms implementations just "platform" to avoid ambiguity around whether I'm including enchanted-shared since it is going to eventually be a full implementation.

@Sparky983 Sparky983 modified the milestones: 1.0.0, 0.2.0 Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Something that relates to the public API discord Specific to any discord (discord4j) implementation implementation Something that relates to the implementation paper Specific to the paper implementation
Projects
None yet
Development

No branches or pull requests

1 participant