Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iscontinuous function not found #199

Closed
hurak opened this issue Mar 12, 2019 · 6 comments
Closed

iscontinuous function not found #199

hurak opened this issue Mar 12, 2019 · 6 comments

Comments

@hurak
Copy link
Contributor

hurak commented Mar 12, 2019

Why isn't the iscontinuous function among the exported (and thus available to users)? I am sure the function is very useful for users, why not exporting it? Was it just an unintended omission?

@olof3
Copy link
Contributor

olof3 commented Dec 19, 2019

Yes, seems like it would be a good idea to export a function with that functionality.

To me iscontinuous feels a little bit imprecise though, the state of a discrete-time linear system is also continuous, and one could think that iscontinuous is true for these systems while being false for boolean statespace models.

On the other hand, function names like iscontinuoustime or is_continuous_time are quite long.
But since the function would probably be used only once in each call, and since it should "soon" be possible to dispatch on continuous and discrete time, it seems like is_continuous_time is a reasonable function name given that it is more precise. I would say I have a weak preference for is_continuous_time. But perhaps someone has a better suggestion altogether.

Anyway, the corresponding isdiscrete or is_discrete_time should also be exported as well.

@hurak
Copy link
Contributor Author

hurak commented Dec 19, 2019

I agree that iscontinuous is imprecise. And I like the proposed is_continuous_time and is_discrete_time.

@freemin7
Copy link
Contributor

Idea:
iscontinous means continous both in value and in time
iscontinous can take an additional type to care just about being continuous in value or being continuous in time.

@mfalt
Copy link
Member

mfalt commented Apr 7, 2020

iscontinous means continous both in value and in time

I am not sure what this would mean in practice. I don't think we have any systems that are not continuous in "value".

I agree that iscontinuous is slightly ambiguous, but I am not a big fan of is_continuous_time. Whatever we choose, it will be exported once we pull this #256 gigantic PR, so we have to make a decision.

@baggepinnen
Copy link
Member

I guess an integer statespace model could be considered as having a discrete state space?

@olof3
Copy link
Contributor

olof3 commented Apr 8, 2020

Is it the length (6 extra characters) that is problem? The function will would not be used that often, at most once in a few functions here and there, and even less when it will be possible to dispatch on the sample time. To me, the slightly longer name is outweighed by the improved clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants