Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

armijo-wolfe: float16 slope coefficient default value unstable #214

Open
d-monnet opened this issue Mar 13, 2024 · 1 comment
Open

armijo-wolfe: float16 slope coefficient default value unstable #214

d-monnet opened this issue Mar 13, 2024 · 1 comment
Labels
bug

Comments

@d-monnet
Copy link
Contributor

d-monnet commented Mar 13, 2024 •
edited
Loading

Keyword argument τ1 of armijo-wolfe default value (0.9999) is rounded up to 1 with Float16. I believe this breaks theoretical convergence of the line-search algorithm.
@dpo
Copy link
Member

dpo commented Mar 13, 2024

How about 1 - eps(T) ?

@tmigot tmigot added the bug label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dpo @tmigot @d-monnet