Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env Regex Match failure #168

Closed
zhangineer2 opened this issue May 15, 2022 · 2 comments · Fixed by #187
Closed

Env Regex Match failure #168

zhangineer2 opened this issue May 15, 2022 · 2 comments · Fixed by #187
Assignees
Labels
bug next release The feature will be added in the next release

Comments

@zhangineer2
Copy link

in the machine.py file
the regex for env is ^(?P<key>\w+)=(?P<value>\w+)$
which does not accurately match IP addresses as a value. I don't think IP addresses will ever be a key.

the following worked for me

^(?P<key>\w+)=(?P<value>\w+.*)$

@Skazza94
Copy link
Member

Hi @zhangineer,
thanks for the issue. I'll open a branch and fix the regex.

Mariano.

@Skazza94
Copy link
Member

Hi @zhangineer,
you can find the fix in the develop branch. We'll merge it in the next release.

Thanks!

@tcaiazzi tcaiazzi added the next release The feature will be added in the next release label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug next release The feature will be added in the next release
Projects
Development

Successfully merging a pull request may close this issue.

3 participants