Support macOS Mojave dark mode

[nrbrook]

I'd love to see Mojave support, I need it for my App. I will look in to adding support if I get chance

[Kentzo]

Sounds great. Please take a look at the #70 by @JanX2. It has updated assets. However, I'm not sure at this point whether it will be merged as is.

[nrbrook]

Thanks, I’ve been working on it today. Do you have any tips on creating the background images - are they copies of existing UI elements? What about the snap back and clear icons?

[Kentzo]

If I recall correctly the assets of the control are based on the button styled as "Textured Rounded". The clear and snap are system assets as is (at least used to be).

I used https://github.com/insidegui/AssetCatalogTinkerer to extract them originally.

@aljungberg may recall more :)

[nrbrook]

When are the 'highlighted' images used and what are they based on?

[Kentzo]

I think originally they were based on the system assets. Then they were redrawn by @aljungberg and then again by @jwells89 in #33.

The control used to draw different background when mouse pointer was over it. This feature was retained although current assets do not have assets for this state.

[Kentzo]

I'm thinking of an abstraction to allow simpler control customization (asset-wise). Do not worry about code.

[jwells89]

@Kentzo I think I still have the Sketch file for this laying around somewhere. Would it be helpful to use them to make dark mode assets?

[nrbrook]

Please see #82

Please improve the assets as you see fit, the photoshop files are in Resources

[Kentzo]

@jwells89 Is it different than https://github.com/Kentzo/ShortcutRecorder/blob/develop/Resources/ShorcutRecorder%20Yosemite.sketch ?

@nrbrook Great Work!

Would it be possible to provide a sketch file instead?
Also please let me know whether new dark mode is based on #82 or current appearance. Would be very helpful, if you could put a button next to the SR control.

[jwells89]

@Kentzo That’s the one, forgot that I committed it.

[nrbrook]

@Kentzo sorry I’ve not used sketch before and did it directly in photoshop. It’s all done with effects though so is editable/transferable.
Dark mode is included in #82. Includes code to load the appropriate images if the appearance changes, as we can’t do it the automatic way using appearance specific assets as we support older macOS (not sure why Apple didn’t seem to consider this possibility and document alternative methods, but I think what I do in #82 is the way it should be done)

[aljungberg]

If I recall correctly the assets of the control are based on the button styled as "Textured Rounded". The clear and snap are system assets as is (at least used to be).

I used https://github.com/insidegui/AssetCatalogTinkerer to extract them originally.

@aljungberg may recall more :)

Yeah I drew them by hand in Photoshop based on UI widgets. It's just some gradients, strokes, a rounded rectangle. I'd probably have used Sketch if I did it today.

[Kentzo]

Part of the Shortcut Recorder 3.0