Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean private needed to create private repo! #1051

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Boolean private needed to create private repo! #1051

merged 2 commits into from
Feb 18, 2022

Conversation

mruell
Copy link
Contributor

@mruell mruell commented Jan 24, 2022

Apparently there was an GitHub API change. When private is not set to true the visibility private is ignored

@mruell
Copy link
Contributor Author

mruell commented Jan 24, 2022

See: https://docs.github.com/en/rest/reference/repos#create-an-organization-repository

@mruell
Copy link
Contributor Author

mruell commented Feb 1, 2022

When do you think this can be merged?
Change is very tiny, but the issue is causing team members not beeing able to create repos, since they are only allowed to create private ones

Would be really happy to see this merged - thanks in advance! :)

@acrobat
Copy link
Collaborator

acrobat commented Feb 1, 2022

Hi @mruell, the change itself looks good! Can you just fix the tests? Thanks!

@mruell
Copy link
Contributor Author

mruell commented Feb 7, 2022

Just fixed the tests :)

@mruell
Copy link
Contributor Author

mruell commented Feb 17, 2022 •
edited
Loading

Hi @acrobat

Any update here?
Seems like it's ready to merge :)

Best,
Marvin

@acrobat acrobat merged commit 4916a94 into KnpLabs:master Feb 18, 2022
@acrobat
Copy link
Collaborator

acrobat commented Feb 18, 2022

Thanks @mruell! And congrats on your first contribution! 🎉

@acrobat
Copy link
Collaborator

acrobat commented Feb 19, 2022

Released in https://github.com/KnpLabs/php-github-api/releases/tag/v3.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mruell @acrobat