Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added environment variables & secrets #1104

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Added environment variables & secrets #1104

merged 5 commits into from
Mar 10, 2023

Conversation

SergkeiM
Copy link
Contributor

@SergkeiM SergkeiM commented Mar 9, 2023

Added environment:

Secrets
Variables

@SergkeiM
Copy link
Contributor Author

SergkeiM commented Mar 9, 2023 •
edited
Loading

Hi @acrobat @Nyholm when have time please review 👍

acrobat
acrobat requested changes Mar 9, 2023
View reviewed changes
lib/Github/Api/Environment/Secrets.php Outdated Show resolved Hide resolved
lib/Github/Api/Environment/Variables.php Outdated Show resolved Hide resolved
@SergkeiM
Removed validation of parameters
cbf08fc 
removed MissingArgumentException
@SergkeiM SergkeiM requested a review from acrobat March 10, 2023 06:57
@acrobat acrobat merged commit acc0453 into KnpLabs:master Mar 10, 2023
@acrobat
Copy link
Collaborator

acrobat commented Mar 10, 2023

Thank you @Froxz

@SergkeiM SergkeiM deleted the feature/env-vars branch March 10, 2023 11:17
@SergkeiM
Copy link
Contributor Author

@acrobat Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SergkeiM @acrobat