Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to PSR-17 and remove deprecated code #888

Merged
merged 5 commits into from
Jul 6, 2020
Merged

Switch to PSR-17 and remove deprecated code #888

merged 5 commits into from
Jul 6, 2020

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jun 28, 2020 •
edited
Loading

This PR removes all the deprecated code from the codebase, and switches to PSR-17 which replaces the old PHP HTTP interfaces, just like PSR-18 replaced some of the others (implemented in an earlier PR).

@GrahamCampbell GrahamCampbell mentioned this pull request Jun 28, 2020
Closed
@GrahamCampbell GrahamCampbell marked this pull request as draft June 28, 2020 19:02
@GrahamCampbell GrahamCampbell marked this pull request as ready for review June 28, 2020 19:22
@acrobat acrobat linked an issue Jun 29, 2020 that may be closed by this pull request
Remove "shadow-cat" preview header #869
Closed
cs278
cs278 reviewed Jul 1, 2020
View reviewed changes
doc/security.md Outdated Show resolved Hide resolved
@GrahamCampbell GrahamCampbell changed the title Removed deprecated code Switch to PSR-17 and remove deprecated code Jul 2, 2020
acrobat
acrobat requested changes Jul 3, 2020
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an upgrade file so users have a summary on what was removed/changed and maybe add some info on what packages to remove/replace to move to the psr18 implementation from an existing setup. thanks!

lib/Github/HttpClient/Plugin/Authentication.php Outdated Show resolved Hide resolved
test/Github/Tests/Api/RateLimitTest.php Show resolved Hide resolved
acrobat
acrobat reviewed Jul 3, 2020
View reviewed changes
lib/Github/Client.php Outdated Show resolved Hide resolved
@acrobat
Copy link
Collaborator

acrobat commented Jul 3, 2020

Thanks for the work already @GrahamCampbell! Just a few comments/changes.

@GrahamCampbell
Copy link
Contributor Author

Just rebased and applied changes based on the feedback.

@GrahamCampbell
Copy link
Contributor Author

@acrobat If you do another 2.x -> master merge, I'll rebase this PR again, so that you don't have additional merge conflicts in the authentication class later on.

@acrobat
Copy link
Collaborator

acrobat commented Jul 4, 2020

Upmerge is done!

@GrahamCampbell
Copy link
Contributor Author

Build green now. :)

@acrobat acrobat merged commit 4619ebd into KnpLabs:master Jul 6, 2020
@acrobat
Copy link
Collaborator

acrobat commented Jul 6, 2020

Thanks a lot for your work on this @GrahamCampbell!

@GrahamCampbell GrahamCampbell deleted the depr branch July 6, 2020 19:24
@GrahamCampbell
Copy link
Contributor Author

No problem. :)

@GrahamCampbell GrahamCampbell mentioned this pull request Jul 30, 2020
Closed
@GrahamCampbell GrahamCampbell mentioned this pull request Sep 10, 2020
Closed
@ocean90 ocean90 mentioned this pull request Feb 20, 2021
Open
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cs278 cs278 cs278 left review comments

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "shadow-cat" preview header
3 participants
@GrahamCampbell @acrobat @cs278