Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved bc check #982

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Improved bc check #982

merged 1 commit into from
Mar 27, 2021

Conversation

acrobat
Copy link
Collaborator

@acrobat acrobat commented Mar 27, 2021

Only run the BC check on PR's and use the PR base branch as target branch to check the BC breaks against, this won't make the BC check fail false-positive on 2.x pr's

@acrobat acrobat merged commit 7d9a5b7 into KnpLabs:2.x Mar 27, 2021
@acrobat acrobat deleted the improve-bc-check branch March 27, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant