Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create a repository using a template endpoint #994

Merged
merged 4 commits into from
Jun 18, 2021
Merged

Add create a repository using a template endpoint #994

merged 4 commits into from
Jun 18, 2021

Conversation

martinbean
Copy link
Contributor

@martinbean martinbean commented Mar 31, 2021 •
edited
Loading

Adds methods to create a repository using a template, and also contributes a few test cases for the various options.

Resolves #976

@martinbean martinbean mentioned this pull request Mar 31, 2021
Closed
acrobat
acrobat requested changes Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an entry to our repo docs, indicating the support for this endpoint? Thanks!

lib/Github/Api/Repo.php Outdated Show resolved Hide resolved
@martinbean
Copy link
Contributor Author

@acrobat Code and docs updated.

acrobat
acrobat requested changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment left, otherwise this PR is ready to be merged! 👌

lib/Github/Api/Repo.php Outdated Show resolved Hide resolved
@martinbean
Copy link
Contributor Author

@acrobat Sorry I left this PR to go stale. I’ve added the type hints to the parameters, and removed the @​param docblocks.

@acrobat acrobat merged commit 02d6c81 into KnpLabs:master Jun 18, 2021
@acrobat
Copy link
Collaborator

acrobat commented Jun 18, 2021

@martinbean no worries! Thanks for the PR!

@martinbean martinbean deleted the feature/create-repo-from-template branch June 19, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat approved these changes

Assignees
No one assigned
Labels
needs-work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method to create a repository using a template?
2 participants
@martinbean @acrobat