Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Tracing Configuration: Missing insecure Field in Limitador CR #141

Open
jsmolar opened this issue May 28, 2024 · 1 comment
Labels
kind/invalid This doesn't seem right

Comments

@jsmolar
Copy link

jsmolar commented May 28, 2024

When configuring tracing for the Authorino Custom Resource (CR), it requires the following configuration:

tracing:
  endpoint: rpc://tempo.tempo.svc.cluster.local:4317
  insecure: true

However, the Limitador CR does not include the insecure field in its tracing configuration. This inconsistency raises the question of whether the omission is intentional or an oversight.

For reference, the documentation on tracing configuration can be found here: Kuadrant Tracing Configuration.

Is this discrepancy intended, or should the Limitador CR also support the insecure field for tracing configuration?

@adam-cattermole
Copy link
Member

This is currently by design. Limitador only supports insecure tracing at present, so to avoid the confusion of the user setting insecure: false with no outcome the field has been excluded until limitador supports secure tracing. I could potentially see an argument for the field to be present set to true with the operator always reconciling changes back to true for now but I think that would be a strange behaviour albeit consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/invalid This doesn't seem right
Projects
Status: No status
Development

No branches or pull requests

2 participants