Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accepted condition to TLSPolicy #642

Closed
3 tasks
maleck13 opened this issue Oct 26, 2023 · 3 comments
Closed
3 tasks

Add Accepted condition to TLSPolicy #642

maleck13 opened this issue Oct 26, 2023 · 3 comments
Labels
Milestone

Comments

@maleck13
Copy link
Contributor

maleck13 commented Oct 26, 2023

What

Based on https://github.com/Kuadrant/architecture/blob/main/rfcs/0004-policy-status.md we want to have some consistent status in place.

One of those status conditions is the Ready condition which is already present in TLSPolicy.

But we want to add a new condition Accepted this is in affect that the controller has validated that the policy is correct and valid and ready to be acted on. Things that may cause this not to be the case

  • TLSPolicy targeting a non gateway resource
  • TLSPolicy targeting a resource that has been deleted or not found
  • Another TLSPolicy being present and targeting the same ref

Done

@maleck13 maleck13 added this to the v0.3.0 milestone Nov 21, 2023
@maleck13 maleck13 removed this from the v0.3.0 milestone Dec 11, 2023
@alexsnaps alexsnaps added this to the v0.4.0 milestone Dec 19, 2023
@philbrookes
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity.

@KevFan
Copy link
Contributor

KevFan commented Mar 4, 2024

This is probably completed as part of Kuadrant/kuadrant-operator#416

@maleck13
Copy link
Contributor Author

maleck13 commented Mar 5, 2024

Agreed we def have teh accepted conditions

@maleck13 maleck13 closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

5 participants