Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing of Polygon::area function on rotated/scaled polygons #1240

Closed
kennyweiss opened this issue Dec 11, 2023 · 0 comments · Fixed by #1249
Closed

Improve testing of Polygon::area function on rotated/scaled polygons #1240

kennyweiss opened this issue Dec 11, 2023 · 0 comments · Fixed by #1249
Assignees
@kennyweiss
Labels
enhancement New feature or request Primal Issues related to Axom's 'primal component Reviewed Testing Issues related to testing Axom
Milestone
April 2024 Release

Comments

@kennyweiss
Copy link
Member

PR #1232 fixed a bug in our Polygon::area() function, but still only tests the function on polygons that are aligned with the XY-, YZ- or XZ- planes.

We should also test this algorithm against polygons that have arbitrary affine transforms (rotation, translation, scaling), after suitably accounting for the changes to area.
@kennyweiss kennyweiss added enhancement New feature or request Primal Issues related to Axom's 'primal component Testing Issues related to testing Axom labels Dec 11, 2023
@kennyweiss kennyweiss mentioned this issue Dec 11, 2023
Merged
@rhornung67 rhornung67 added this to the April 2024 Release milestone Dec 18, 2023
@kennyweiss kennyweiss mentioned this issue Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennyweiss kennyweiss

Labels
enhancement New feature or request Primal Issues related to Axom's 'primal component Reviewed Testing Issues related to testing Axom
Projects
None yet
Milestone
April 2024 Release
Development

Successfully merging a pull request may close this issue.

Pr from fork/1232 LLNL/axom
2 participants
@kennyweiss @rhornung67