Improvements to annotations API #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These allow us pass the region names to caliper to ensure they match.
Credit: based on feedback from D. Boehme
And uses it in all current examples w/ caliper support.
kennyweiss
added
enhancement
kennyweiss
requested review from
white238,
cyrush,
BradWhitlock,
rhornung67,
publixsubfan,
ltaylor16,
agcapps and
bmhan12
agcapps
approved these changes
Apr 11, 2024
BradWhitlock
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
caliperandadiakin the annotations API based on an offline code review of Adds annotations API and macros to axom #1312 from @daboehme (Thanks!)AXOM_ANNOTATE_ENDmacro require anameparameter? #1315 by using a caliper function call that uses thenamepassed toaxom::utility::annotations::end(name)