Close database on environment exit #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Looks really nice! |
vweevers
force-pushed
the
close-on-environment-exit
branch
from
66454c8
to
6a624ed
Compare
ralphtheninja
approved these changes
Sep 11, 2021
15 tasks
4 tasks
jonathan-gramain
added a commit
to scality/s3utils
that referenced
this pull request
Sep 28, 2022
This brings the leveldown version to 6.1.0 which has fixes that could prevent an assert from happening in leveldb. Level/leveldown#783 Level/leveldown#755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #667, closes #755.