General fixes for TLS #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was tested in airtime web and with integration of media-monitor and silan up and running. It might work for pypo but that needs testing.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old one from my legacy upstream fork and takes care of allowing the api client to access files from the library through tls if the tls listener is on port 443.
It also has a fix for the API where it would build a
https://<hostname>:80url instead ofhttps://<hostname>:443. A more serious fix would probably make the URL configurable on not depend on$_SERVERas much, but this works.For it to also work we would need to make the protocol fully configurable. At least with this things won't completely fail if you switch the install to 443 and close off 80.